Skip to content

fix(team): improve lookups, event handling and distribution array bounds#66

Merged
theEvilReaper merged 9 commits into
developfrom
feature/team-improvements
Jul 24, 2026
Merged

fix(team): improve lookups, event handling and distribution array bounds#66
theEvilReaper merged 9 commits into
developfrom
feature/team-improvements

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

The pull request improves the definition of the included Team. Now a team is stored via a key from Adventure which makes it easier to access than a global id or the reference of them.

StandardTeamService now uses a ConcurrentHashMap for thread-safe O(1) lookups, fixing exceptions when fetching missing teams. Player mutations are now executed inside event callbacks to respect event cancellation, and team distribution fixes prevent premature loop aborts and array bounds errors when teams reach full capacity.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Jul 22, 2026
@theEvilReaper theEvilReaper changed the title fix(tema): improve lookups, event handling and distribution array bounds fix(team): improve lookups, event handling and distribution array bounds Jul 22, 2026
@theEvilReaper
theEvilReaper force-pushed the feature/team-improvements branch from 0f2e485 to 5b8800b Compare July 24, 2026 09:18
@theEvilReaper
theEvilReaper merged commit be1e2d0 into develop Jul 24, 2026
3 checks passed
@theEvilReaper
theEvilReaper deleted the feature/team-improvements branch July 24, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant