fix(frontend): stabilize label-set workflows - #2296
angelo-lacson wants to merge 1 commit into
Conversation
Normalize label colors for the GraphQL validator, respect mutation results before reporting success, and keep creation controls accessible for populated sets. Propagate the selected label-set object so the corpus modal reflects controlled selection changes immediately.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Thanks for this — nice cleanup. Can you just make sure the non-Claude actions pass and I'd be happy to merge this? 1.
|
GitHub clamps pull_request runs whose head is a fork: the id-token: write this workflow declares is silently dropped and the secret store is withheld (Secret source: None, claude_code_oauth_token: ""). The action then dies on "Could not fetch an OIDC token. Did you remember to add `id-token: write` to your workflow permissions?" — an error that accuses the workflow file for a permission it already declares, sending anyone debugging from the message alone to edit correct code. Approving the run does not restore secrets, and GITHUB_TOKEN is read-only on fork PRs, so the `gh pr comment` the job is asked to make could not post either. Guard the job on head.repo.full_name == github.repository so it reports skipped — which is what actually happens — rather than a red X no contributor can clear. Dependabot branches live in this repository, so they pass the guard and the OIDC exchange works unchanged. Observed on run 33611167884 (PR Open-Source-Legal#2296); dependabot control is run 33788653880.
|
Sorry wanted to merge this. See PR #2328 |
Summary
Fixes the misleading state and validation failures encountered while creating labels and assigning a label set during corpus creation.
Fixes #2295.
Changes
#RRGGBBvalue while keeping native color inputs stable for stored values with or without#.createAnnotationLabelForLabelsetmutation payload, report backend failures accurately, and await refreshed label-set data before closing the create form.LabelSetTypefromLabelSetSelectorso controlled consumers such asCorpusModalimmediately display the user's selection.changelog.dfragment.Test plan
NODE_OPTIONS=--max-old-space-size=4096 yarn buildvia the frontend Docker builder — passed (TypeScript and Vite production build).python3 scripts/collate_changelog.py --check— passed.Checklist
pre-commit run --all-filespasses (not run locally)yarn buildoryarn lint), if frontend code changedchangelog.d/for the user-facing fixesContributor License Agreement
By submitting this pull request, I agree to license this contribution under the project's Contributor License Agreement.