Conversation
Reject top-level object message content before Gateway/session mutation while preserving string and array paths, in both buffered and streaming modes. Focused spec 6/6. Refs OpenBMB#501.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #501.
Root cause: top-level object message content was silently stringified to [object Object]\ before Gateway/session handling.
Behavior change:
ormalizeContent\ now returns
ull\ for top-level objects; the API server answers HTTP 400 \invalid_content\ before Gateway/session mutation or SSE admission, in both buffered and streaming modes. String and supported array content paths are unchanged.
Regression coverage: focused spec \ ests/adapters/channel/api-server-content-object.spec.ts, 6/6 passing locally (arbitrary-object buffered/streaming, object-part buffered/streaming, string passthrough, array preservation; zero Gateway calls and zero session admission on every rejection path).
Note: full
pm\ build/test were not run locally (environment provides Node 24 while the repo requires Node 22); please let CI verify broader compatibility.