feat(settings): expose subagent execution timeout - #579
Open
changer-changer wants to merge 1 commit into
Open
changer-changer wants to merge 1 commit into
changer-changer wants to merge 1 commit into
Conversation
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subagent runs already honor
agent.subagents.timeoutMs, but users must edit YAML to change it. This adds a maximum run time field, in seconds, to the existing Agent Model advanced settings, with English and Chinese help text. Clearing the field restores the existing one-hour default and preserves other subagent settings.The native number input accepts optional bounds so invalid or overflowing durations cannot be committed. Fractional seconds round to milliseconds; the backend timeout mechanism and default behavior are unchanged. This change is independent of #576.
Validation:
--maxWorkers 2: 191 files / 1,533 tests passed.90.125seconds becomes90125milliseconds, zero cannot be saved, and clearing removes only the override. Production config normalization preserves the value.Merge sequencing (added 2026-09-14)
This PR is one of four coordinated subagent-lifecycle PRs (#579, #576, #580, #581). The features are semantically independent but overlap textually in the agent core, so an explicit merge order is proposed in #583.
Proposed order: #579 → #576 → #580 → #581 (this PR: 1 (first)).
This branch's known conflicts: clean against current
mainand against #580/#581; a single shared UI file with #576 (modelPool/types/index.ts).After each sibling PR merges, I will rebase the remaining branches onto
mainand re-run the targeted test suites before updating the PRs.