fix(channels): route handoff reply ack by channel - #227
Open
Caldalis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
/回复反馈(alias/handoff_reply) is dispatched on every channel, but the acknowledgment it stages hard-codes a Feishu-shaped delivery target (receive_id/receive_id_type). WeCom and WeChat readto_user_id, DingTalk readssession_webhook, so on those three the ack is undeliverable: the handoff resolves, the assignee gets no confirmation, and a failed delivery is left behind. WeCom is hit hardest — it is inHANDOFF_NOTIFY_CHANNELS, and the notification it sends tells the assignee to reply with this exact command.Changes
ChannelInboundEvent.target_json, or theprocess_inboundfallback for WeChat) into_run_handoff_reply_commandand use it for the ack, as every other command reply does.source=binding.channelinstead of a hard-coded"feishu".Risk
On Feishu the ack now replies to the command message instead of sending a new DM, since the staged target carries
message_id. This matches every other Feishu command reply. The identical hard-coded target in_stage_feishu_assignee_replyis left alone — it is only reachable inside thebinding.channel == "feishu"branch.Tests
New
test_channel_handoff_reply.py(11 cases): per-channel ack target and recorded source, plus a guard asserting the WeCom/WeChat/DingTalk adapters reject a Feishu-shaped target. Updated the 7 existing call sites intest_feishu_handoff.py. Full suite 2008 passed (1997 before);ruff checkclean on changed files.UI Validation
Not applicable — backend channel intake only, no route or role affected.
No existing issue; found while auditing channel capability parity.