Conversation
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🔵 Needs a closer look
The tenBitWarning.dismiss translations in 11 locale files are currently ignored.
Pull request overview
Adds tenBitWarning localization entries to Crowdin-managed locale catalogs and normalizes formatting in locales/en.json.
Changes:
- Adds 10-bit warning strings to 11 locales.
- Normalizes English catalog indentation.
File summaries
| File | Change | Finding |
|---|---|---|
locales/zh.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/tr.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/ru.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/ro.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/pl.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/nl.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/ko.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/ja.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/fr.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/es.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
locales/en.json |
Formatting normalization | No final review comment. |
locales/de.json |
Adds warning strings | Moderate (1 vote): tenBitWarning.dismiss is ignored due to duplicate qsTr("Got it") lookup. |
Review details
Suppressed comments (11)
locales/de.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/es.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/fr.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/ja.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/ko.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/nl.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/pl.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/ro.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/ru.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/tr.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
locales/zh.json:6
- This entry is not selected by the current Qt translation path:
TenBitWarningDialog.qmlcallsqsTr("Got it"), whileLocalizationmaps duplicate source text to the first sorted key,releaseHighlights.gotIt, so thistenBitWarning.dismissvalue is ignored. Switch the dialog to the key-basedI18n.text("tenBitWarning.dismiss")(or make the source text unique) before relying on this translation.
"dismiss": "Got it"
- Files reviewed: 11/12 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
No description provided.