Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit and implementation against the latest
devbase, including783db41f. The full evidence-backed comparison with OpenNOW-Mac is in docs/alliance-library-audit.md.Library delivery and recovery
The core previously aggregated up to 2,000 games into one result while Qt rejects protocol lines over 1 MiB. Library now uses complete cursor pages capped at 100 games and 768 KiB, sharing the Store page-budget implementation. Oversized pages retry at the same cursor with a smaller count, without skipping rows.
Qt appends/deduplicates pages progressively, retains search on retry, cancels stale account/disconnect requests, and rejects cyclic or malformed pagination. Missing apps/items are errors rather than empty success. Desktop and console preserve partial results alongside a visible error and retry action.
Mac reference parity
vpcId/vpc_idbefore the server-ID fallback. Route discovery through the configured proxy and separate metadata caches by route; subscription uses the same route.Verification
The affected external tester's authenticated response is still unavailable. These are demonstrated client defects and reference-parity fixes, not proof that the tester's account now loads. The separate RTSPS Transport investigation in #883 remains outside this PR.
Visual acceptance: mocked partial-library failures, not a live account