Skip to content

fix(qml): pass codec argument through in codecDisabledByProfile - #995

Merged
zortos293 merged 1 commit into
devfrom
fix/codec-profile-passthrough-typo
Sep 19, 2026
Merged

zortos293 merged 1 commit into
devfrom
fix/codec-profile-passthrough-typo

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

Summary

One-line fix: the \codecDisabledByProfile\ ShellStore passthrough referenced \code\ instead of \codec, throwing \ReferenceError\ whenever decoder capabilities made the desktop codec-row bindings evaluate. This broke 4 Linux packaging acceptance tests (\qml-language-colors-desktop, \qml-frame-rate-settings-desktop-900/1400, \qml-backend-availability) that advertise available codecs in fixtures.

Verification

  • PR checks (same suites that caught it).

ReferenceError (code vs codec) broke the desktop codec row bindings whenever decoder capabilities were present, failing settings-streaming acceptance on capability fixtures.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a3235893-ee40-442d-a13c-d35d417e9677

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zortos293
zortos293 merged commit 05de258 into dev Sep 19, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant