fix(updates): quote MSI INSTALL_ROOT to avoid msiexec 1639 and clear terminal transactions

[zortos293]

Summary

• Fixes Windows MSI updates failing with msiexec error 1639 plus a help dialog: INSTALL_ROOT is now passed as a raw PROPERTY="value" token (quotes only around the value) so paths with spaces parse correctly, and MSI/package/log paths containing quotes or control characters are rejected with a clear error.
• Adds a verbose msiexec log (/l*v msiexec.log) in the staging directory and includes its path in failure messages for diagnostics.
• Terminal helper outcomes (succeeded/rolled-back/failed) are reported for one launch only; the persisted active transaction is cleared after first reconciliation so a stale failure dialog no longer reappears on every restart.
• Unreadable active-apply.json is dropped at startup/check/download/apply boundaries so one corrupt file cannot block future updates.
• Updates docs/core-protocol.md to document the report-once-then-clear terminal outcome behavior.

Test notes

• cargo test on opennow-core: 115 lib + 484 bin tests passed.
• Focused suites: update_apply::managed 3/3 passed, updater 25/25 passed.
• Working tree contains only these three files in this PR; unrelated untracked scratch file (nvidiagrid-subdomains.txt) was left out.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 097c8730-b45b-447c-aaf1-3878990b7ded

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}