fix(streamer): stop SETUP at first 200 and fall back to bundle peer when rigs omit Transport - #998
Merged
Merged
Conversation
…hen rigs omit Transport Live YES/ABYA rigs 200 the first video SETUP with an empty Transport header and 400 every further form; ANNOUNCE after such a burst is then rejected, while a single SETUP followed by ANNOUNCE succeeds. Sweeping all forms poisons these sessions, and the old code did exactly that. Stop each sweep at the first 200 (with or without a peer). Peerless 200s still re-issue the same stopped-at form on the bounded #993 pace for late-starting encoders, and terminal exhaustion with a CloudMatch bundle peer proceeds on it (mirroring the official client, which carries on when the server omits transport) instead of failing the seat. Pure rejections still fail fast; the first SETUP request is byte-identical. Also adds redaction-safe DESCRIBE shape logging and an OPENNOW_STREAMER_LOG_FILE sink for the standalone child so headless negotiation failures stay diagnosable.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live YES/ABYA rigs 200 the first video SETUP with an empty Transport header and 400 every further form; ANNOUNCE after such an 8-SETUP burst is then rejected (400), while a single SETUP followed by ANNOUNCE succeeds (proven with a raw-protocol prober on a live YES seat, 2 rigs x 2 games). Sweeping all forms poisons these sessions.
This stops each sweep at the first 200 (with or without a peer). Peerless 200s still re-issue the same stopped-at form on the bounded #993 pace for late-starting encoders, and terminal exhaustion with a CloudMatch bundle peer proceeds on it (mirroring the official client, which carries on when the server omits transport) instead of failing the seat. Pure rejections still fail fast without retries, and the first SETUP request is byte-identical, so all previously-working paths are unchanged.
Also adds redaction-safe DESCRIBE shape logging (\describe-shape) and an \OPENNOW_STREAMER_LOG_FILE\ sink for the standalone child so headless negotiation failures stay diagnosable (previously all \log_line\ output was silently dropped there).
Verification