make server.py compatible with Python3.13#737
Open
karamyaqin wants to merge 1 commit into
Open
Conversation
The script had one breaking issue for Python 3.13: it called ssl.wrap_socket(), which was deprecated in 3.7 and fully removed in Python 3.12, so start() would immediately throw AttributeError: module 'ssl' has no attribute 'wrap_socket'. I confirmed this by running the original file's logic against a 3.12 interpreter here. I replaced that call with the supported ssl.SSLContext equivalent: build a context with the same protocol from self.auth_suite.protocol, load the cert/key chain and CA file, set the same cipher string, then call context.wrap_socket(...) with the same server_side, do_handshake_on_connect, and suppress_ragged_eofs arguments. The resulting TLS behavior (protocol version, mutual-auth cert requirement, cipher list) is unchanged. I also dropped the six import and its one use (six.iteritems(policies) → policies.items()), since this is a pure Python 3 codebase now and six's only job here was a Python 2/3 dict-iteration shim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script had one breaking issue for Python 3.13: it called ssl.wrap_socket(), which was deprecated in 3.7 and fully removed in Python 3.12, so start() would immediately throw AttributeError: module 'ssl' has no attribute 'wrap_socket'. I confirmed this by running the original file's logic against a 3.12 interpreter here. I replaced that call with the supported ssl.SSLContext equivalent: build a context with the same protocol from self.auth_suite.protocol, load the cert/key chain and CA file, set the same cipher string, then call context.wrap_socket(...) with the same server_side, do_handshake_on_connect, and suppress_ragged_eofs arguments. The resulting TLS behavior (protocol version, mutual-auth cert requirement, cipher list) is unchanged. I also dropped the six import and its one use (six.iteritems(policies) → policies.items()), since this is a pure Python 3 codebase now and six's only job here was a Python 2/3 dict-iteration shim.