feat: Import TheChadSurvivor/Holocron-Toolset-Moded changes#1
feat: Import TheChadSurvivor/Holocron-Toolset-Moded changes#1oldrepublicwizard wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a80ff9273
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def main_init(): | ||
| sys.excepthook = onAppCrash | ||
| is_main_process: bool = multiprocessing.current_process() == "MainProcess" |
There was a problem hiding this comment.
Detect main process correctly before multiprocessing setup
multiprocessing.current_process() returns a process object, so comparing it to the string "MainProcess" is always false. That means the is_main_process branch never executes, so set_start_method("spawn") and atexit.register(last_resort_cleanup) are skipped on every run. In the environments this code targets (especially Linux/macOS), this defeats the intended protection against fork-related updater issues and skips shutdown cleanup registration.
Useful? React with 👍 / 👎.
| try: | ||
| print(f" {attr}: {getattr(obj, attr)}") | ||
| except Exception as ex: # noqa: BLE001 | ||
| print(f" {attr}: Unable to retrieve value ({ex.__class__.__name__}: {ex})") | ||
| print(f" {attr}: Unable to retrieve value ({ex.__class__.__name__}: {e})") |
There was a problem hiding this comment.
Use the caught exception variable in Qt debug print helper
This except block binds the exception as ex but formats {e} in the message, which raises a new NameError whenever an attribute access fails. In practice, print_qt_object will crash during the exact error path it is meant to report, masking the original exception and breaking diagnostic output.
Useful? React with 👍 / 👎.
…origger from TheChadSurvivor
…er, and resource selection handlers
1a80ff9 to
29bb099
Compare
… readability and maintainability
Summary
Import code changes from TheChadSurvivor/Holocron-Toolset-Moded into OldRepublicDevs/HolocronToolset for review.
What's included
Modified files (165 existing files)
New files (39 new files)
esources_rc_pyqt5.py,
esources_rc_pyqt6.py,
esources_rc_pyside2.py,
esources_rc_pyside6.py\
Important notes
Source