Add createMosaic mutation and related functionality - #4012
Conversation
nellh
left a comment
There was a problem hiding this comment.
A few comments. This looks pretty good, if we're keeping the mosaics in the datasets volume we'd just need an endpoint to serve them (on_get for the mosaic handler would work) and a resolver for that. The advantage of moving them into a branch is we could reuse the git object endpoint to stream them but that might not be worth the added complexity.
Let's start with an admin tab button to trigger mosaic creation and automate if that seems to be working well?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4012 +/- ##
==========================================
+ Coverage 50.27% 50.32% +0.05%
==========================================
Files 696 701 +5
Lines 38930 39201 +271
Branches 2122 2123 +1
==========================================
+ Hits 19571 19728 +157
- Misses 19189 19303 +114
Partials 170 170 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This sets up the basics for incorporating the bids-mosaic tool into openneuro:
I haven't added any tests yet but happy to do so once everything else is ready to go.
I thought I would start with the basics here and then we can discuss whether we want to incorporate it within the UI and/or have it be auto-triggered. Another idea from @effigies was to keep the 2D images annexed in a separate branch so unchanged images don't have to be regenerated when running on a future snapshot (currently they get created in /tmp and then deleted).