Fix Integer overflow in httpGetDateTime() - #1717 - #1718
Open
PavlNekrasov wants to merge 1 commit into
Open
PavlNekrasov wants to merge 1 commit into
PavlNekrasov wants to merge 1 commit into
Conversation
Member
|
In the future, please combine bug report and PR into a single PR with the full explanation of the bug. Doing both just gives both of us extra work. |
Member
|
Also, please start signing your commits... |
Problem: httpGetDateTime() never range checks day, hour, min, sec and the lower bound of year after sscanf(), so they overflow in the int arithmetic that follows. The date string is remote input - cupsd feeds it the If-Modified-Since request header. Solution: Range checked day, hour, min, sec and year right after sscanf(). Signed-off-by: p.nekrasov@fobos-nt.ru Signed-off-by: Timofei Fedotov sovtouch@altlinux.org
PavlNekrasov
force-pushed
the
fix-integer-overflow-httpgetdatetime
branch
from
September 25, 2026 12:44
7e9c8b5 to
da4902f
Compare
Author
|
The commit has now been signed and forced-pushed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #1717
Solution:
Range checked day, hour, min and sec and added the missing lower bound on year right after sscanf(), so every following expression stays inside int.
Signed-off-by: p.nekrasov@fobos-nt.ru
Signed-off-by: Timofei Fedotov sovtouch@altlinux.org