fix(deps): bump smol-toml to 1.7.1 (GHSA-7w5x-hrqm-74c2) - #94
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Fixes GHSA-7w5x-hrqm-74c2 (CVE-2026-85730): parse() infinite loop on malformed TOML. Co-Authored-By: Robert Yeakel <robert.yeakel@openrouter.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
Original prompt from Robert
|
5 tasks
bjoerndanz
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Bumps
smol-toml1.6.1 → 1.7.1 so the harness no longer resolves a version affected by GHSA-7w5x-hrqm-74c2 (CVE-2026-85730, high):parse()loops forever on malformed input such asa=[1 #.What changed?
package.jsondependencysmol-toml1.6.1→1.7.1bun.lockresolvessmol-toml@1.7.1(sha512PPlsspAZ…, same artifact the openrouter-web root lockfile already pins via itsoverrides);modal@0.8.0(^1.3.3) shares the single copyWhy?
src/benchmarks/{terminal-bench,swe-atlas,wandr,deep-swe}/dataset.ts, so a malformed task file would pin a worker CPU indefinitely.packages/bench-harnessthere is a vendored subtree guarded byscripts/check-subtree-integrity.ts, so the declaration can only move here and then be pulled withscripts/subtree-pull-bench-harness.sh. The grouped Dependabot PR lineage (#47 → #57 → #71, all closed unmerged; #82 open) bundles this with a majorcsv-parsebump, so this is the smol-toml-only split SEC-360 asks for. If deps: bump the dependencies group across 1 directory with 18 updates #82 lands first this PR becomes a no-op.Source row: https://app.notion.com/p/3da2fd57c4dc813e885eefc714ef32a3 · dedup key:
DEPS-smol-toml-1.7.1-GHSA-7w5x-hrqm-74c2How to test
bun install --frozen-lockfilesucceeds andrg 'smol-toml@' bun.lockprints exactly one entry,smol-toml@1.7.1.timeout 20 bun -e 'import {parse} from "smol-toml"; parse("a=[1 #")'exits promptly withTomlError: Invalid TOML document: cannot find end of structure(on 1.6.1 this never returns).Reviewer focus
format:check,check,typecheck,bun test(1450 pass) andbuildis green.Checklist
Supersedes #88 (same branch, reopened under the requesting user's identity).
Link to Devin session: https://openrouter.devinenterprise.com/sessions/07a2fc6a827a4f6089b5a71000f926ac
Open in Devin Desktop: https://openrouter.devinenterprise.com/desktop/session/07a2fc6a827a4f6089b5a71000f926ac?variant=devin
Requested by: @robert-j-y
Note
Devin errored when opening this Pull Request as robert-j-y.
As a fallback, Devin opened this PR as itself.