Skip to content

security(dci): fail closed on unresolved search sender + cap page_size#260

Merged
gonzalesedwin1123 merged 3 commits into
19.0from
security-dci-search-consent
Jun 30, 2026
Merged

security(dci): fail closed on unresolved search sender + cap page_size#260
gonzalesedwin1123 merged 3 commits into
19.0from
security-dci-search-consent

security(dci): treat non-positive max_page_size as default, not no-cap

c53967d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 30, 2026 in 0s

75.22% (+0.46%) compared to f04d936

View this Pull Request on Codecov

75.22% (+0.46%) compared to f04d936

Details

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.22%. Comparing base (f04d936) to head (c53967d).

Files with missing lines Patch % Lines
spp_dci_server_social/services/search_service.py 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0     #260      +/-   ##
==========================================
+ Coverage   74.75%   75.22%   +0.46%     
==========================================
  Files        1090     1092       +2     
  Lines       64813    64900      +87     
==========================================
+ Hits        48453    48818     +365     
+ Misses      16360    16082     -278     
Files with missing lines Coverage Δ
spp_dci_server/middleware/signature.py 91.53% <100.00%> (+0.06%) ⬆️
spp_dci_server/models/transaction.py 80.56% <100.00%> (+0.37%) ⬆️
spp_dci_server/routers/async_router.py 92.52% <100.00%> (+0.13%) ⬆️
spp_dci_server/routers/search.py 90.80% <100.00%> (+0.32%) ⬆️
spp_dci_server_social/services/search_service.py 89.93% <75.00%> (-0.39%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.