Document the mc-image-helper CVEs as assessed and accepted - #18
Merged
Conversation
Six open Trivy findings, one critical, all inside the base image's mc-image-helper and none of them dependencies this repo chooses or can upgrade: scala-library 2.13.1 (CVE-2022-36944, critical), jackson-databind 3.1.3 (two highs), jackson-core 3.1.3, and micrometer-core 1.16.5 (the two highs PR #16 tried and failed to clear). Bumping the base image again would be churn, not a fix. MC_HELPER_VERSION on itzg's master is still 1.66.0, the version already running here, so a newer digest would change the image without changing a single affected library. PR #16 said the Trivy scan would be the verdict on that bump; the verdict is in and it did not carry the fix. The exposure assessment is deliberately not uniform, because the CVEs are not equivalent. micrometer needs a gRPC or HTTP endpoint that mc-image-helper does not serve, and scala needs Java deserialization it never performs. But jackson is different and is written up as such: the tool does parse JSON fetched from remote APIs at container start, so there is a real if narrow path there. Calling that zero-exposure would have been the comfortable answer rather than the true one. Deliberately NOT adding a Trivy ignore file. Suppressing these hides the critical and trains everyone to ignore the scanner, which matters far more the day a finding lands in our own code. Six assessed and documented findings beat zero findings and a suppression list nobody rereads. Trigger for re-evaluation is MC_HELPER_VERSION moving past 1.66.0, not a calendar date, with a backstop review at 2026-11-14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six open Trivy findings, one critical. All are inside the base image
mc-image-helper, none are dependencies this repo chooses or can upgrade.Bumping again will not help, and I checked rather than assuming
PR #16 bumped the base image specifically to clear the micrometer pair, and said in advance that the Trivy scan would be the verdict. The verdict is in: they are still here.
Checked again today: a newer
java21build exists, butMC_HELPER_VERSIONon itzg master is still 1.66.0, which is what we already run. A further digest bump would change the image without changing a single affected library. That is churn dressed as remediation.The fix has to come from upstream updating mc-image-helper dependencies.
The assessment is not uniform, because the CVEs are not
Container hardening bounds all of it: read-only rootfs, uid 1000, all caps dropped, no-new-privileges, pids capped, no Docker socket.
Explicitly not adding a Trivy ignore file
Suppressing these hides the critical and trains everyone to ignore the scanner, which matters far more the day something lands in our own code. Six assessed, documented findings beat zero findings and a suppression list nobody rereads. The noise is the price of the signal.
Review trigger
MC_HELPER_VERSIONmoving past 1.66.0, not a calendar date, with a backstop review at 2026-11-14.Next action is an upstream report to
itzg/mc-image-helper, which fixes this for every user of the image rather than just us.