feat(persona): show links between faces that no attribute holds - #263
Merged
Merged
Conversation
The agent now reports a value that only faces carry -- typed into a face as an inline entry, or shown in place of an attribute by an override -- as a correlation finding with no attributeId, because there is no attribute. The identity map places findings on attribute cards, so such a finding was counted in the summary and drawn nowhere. List them in the correlation note, naming the faces: by the holder's own name where the console holds the face, and by context for a context-local face the console does not list. faceOnly, facesNamed and facesWords live in correlation-model.ts beside the ranking so the summary and the rows read one model. The empty-state copy no longer says the check covers attributes only. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent now reports a value that only faces carry as a correlation finding with no
attributeId, because there's no attribute. "Carry" means typed into a face as an inline entry, or shown in place of an attribute by an override. The identity map places findings on attribute cards, so such a finding would be counted in the summary but drawn nowhere — the numbers wouldn't close.This lists those findings in the correlation note and names the faces:
faceOnly,facesNamedandfacesWordslive incorrelation-model.tsnext to the ranking, so the summary and the rows read the same model. The empty-state copy no longer claims the check covers attributes only.This is harmless against an older agent, which never emits such a finding.
Agent side: OpenVTC/verifiable-trust-infrastructure
fix/persona-correlation-face-values. Spec: trustoverip/dtgwg-trust-tasks-tf#533.Checks
npm run lintnpm test— all workspaces green, including the newmanager-correlation-modeltestnpm run build