feat(persona): a face says which name is its own; old values kept for a pin, and removing them - #265
Merged
Merged
Conversation
… a pin, and removing them Uses @openvtc/trust-tasks 0.19.14 (trustoverip/dtgwg-trust-tasks-tf#538). Face editor -- CALLS ITSELF: pick which of the attributes a face shows is its own name (the entry's `displayName` slot). A face can show a legal name and the one it goes by; this says which is the face's. The choice is offered only from what the face shows, and a name typed into the face itself is kept unless the holder picks another. composeEntriesWithSlots keeps every slot through an edit. profile/put replaces the face, so rebuilding live entries as bare {ref} -- what composeEntries does -- would strip the name on the first save. The NAME hint no longer says contexts see the face's name: since verifiable-trust-infrastructure#1597 a context sees only the label the holder chooses when a persona wears the face. Attribute strip -- kept values: when the agent keeps an earlier value because a face is pinned to it (Attribute.retainedVersions), the strip says so and which faces are the reason. "Remove the old value for good" calls persona/attribute/purge-version after a confirmation that says the pinned faces will show nothing -- not the current value -- and that anyone already shown the old value keeps it. Model in kept-versions.ts. Wiring: personaAttributePurgeVersion in core admin; the URI added to both CI holder-only guards; task-surface.json resynced (vta-sdk 0.45.1) and the recorded coverage moved 205 -> 206 with the reason. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
@openvtc/trust-tasks0.19.14 (trustoverip/dtgwg-trust-tasks-tf#538). The agent side is OpenVTC/verifiable-trust-infrastructure#1605 (slots) and #1606 (kept versions,purge-version). Merge after those land and are released: an agent without #1606 doesn't routepurge-version.Face editor — "Calls itself"
displayNameslot.composeEntriesWithSlotscarries every slot through an edit.profile/putreplaces the whole face, and rebuilding live entries as bare{ref}would have dropped the name on the first save.Attribute strip — kept values
persona/attribute/purge-version, after a confirmation that says:manager/kept-versions.ts.Wiring
personaAttributePurgeVersionin core admin.task-surface.jsonresynced fromvta-sdk0.45.1.@openvtc/trust-tasks^0.19.14 at the root and in core. The lockfile changes that one package only.Checks
npm run lintnpm test: 1547 passed, 0 failed. New:manager-kept-versions.test.mtspurge-versionclient testnpm run build, plus both persona guards run locally againstdist/.