Add unofficial BSD support - #810
Conversation
| { | ||
| "name": "bsd-x64-relwithdebinfo", | ||
| "configurePreset": "bsd-x64", | ||
| "configuration": "RelWithDebInfo" |
There was a problem hiding this comment.
| "configuration": "RelWithDebInfo" | |
| "configuration": "RelWithDebInfo" |
There was a problem hiding this comment.
i don't know why it isn't applying properly.
when i pull the changes down it doesn't have this problem either.
| link_libraries(${ICONV_LIBRARY}) | ||
| endif() | ||
|
|
||
| add_subdirectory(deps) |
There was a problem hiding this comment.
Why was deps moved down here?
There was a problem hiding this comment.
so the makefile it's jumping to knows about iconv
| ) | ||
|
|
||
| if(CMAKE_SYSTEM_NAME STREQUAL "Linux") | ||
| # all unix non apple systems need tbb this way |
There was a problem hiding this comment.
Please follow the style FakeByte used for comments to keep consistency.
| # if needed detect other platforms | ||
|
|
There was a problem hiding this comment.
Please follow the style FakeByte used for comments to keep consistency. Also remove the newline spacing.
|
Also please change the commit message and PR to be specific about what this is doing, PRs and commit messages should describe what/why they're doing something, that's the style your commits should be doing, in this case it should say something like "Add unofficial BSD platform support" or something. |
Spartan322
added
enhancement
Signed-off-by: Benjamin Lee McQueen <mcq@disroot.org> comment fixes
983f838 to
3bc78e1
Compare
3 participants
this PR makes it so that we link TBB if(UNIX AND NOT APPLE) instead of Linux for portability and semantic reasons.
it also adds BSD as a preset which is bsd-x64
unsure if i should make changes in the README because of "official support," but if it's needed it can probably be included when the README is updated or as a standalone fix.