fix(db): open a database whose keyword index was built by an older version - #548
Open
kevintseng wants to merge 1 commit into
Open
kevintseng wants to merge 1 commit into
kevintseng wants to merge 1 commit into
Conversation
…rsion A small database last opened by an older version (before 4.2.11, or with Thai, Lao, Khmer, half-width katakana or rare CJK characters) failed to open with "database disk image is malformed". The title backfill removed index rows using today's word splitting before the index had been rebuilt, so the removal did not match what was stored. The index is now rebuilt first. Fixes #522
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #522.
What was wrong
A small database last opened by an older version could not be opened. Every command reported "database disk image is malformed", even though the database was fine. This happened when the database was older than 4.2.11, or when it held Thai, Lao, Khmer, half-width katakana or rare CJK text indexed by an older version.
What changed
When a database opens, it now rebuilds its keyword index before the step that fills in missing titles. That step removes old index rows, and it can only remove them correctly after the index has been rebuilt.
Tests
tests/db-old-index-opens.test.tscovers two cases: a Chinese database from before segmentation, and a Thai database from before Thai segmentation. Both fail without the fix and pass with it.npm run verifyis green.