fix(mcp): accept a null message payload, as the schema and the HTTP API do - #557
Merged
Merged
Conversation
…PI do `message` `send` over MCP refused `payload: null` with "payload: Invalid input", although the tool's schema lists null and `POST /v1/message` and the CLI store it. The MCP boundary drops null-valued top-level parameters as "left blank"; for `payload` a null is the value itself, so it is kept. Refs #553
A regression test drives the built MCP server over stdio: `send` with `payload: null` succeeds, `fetch` returns `payload: null`, and a send with no payload, or a payload on `fetch`, is still refused. The boundary comment and the changelog now say that a null `payload` is a value, the one exception to "a null top-level parameter means left blank". Refs #553
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #553.
What was wrong
The MCP
messagetool refusedsendwithpayload: null("payload: Invalid input"), although the tool's own schema listsnulland the HTTP API and the CLI accept it and store it.What changed
payload: nullonsendis accepted over MCP and stored asnull;fetchreturns it. A top-levelnullon any other parameter still means "left blank", and apayloadon any action other thansendis still refused.Tests
tests/transports/mcp-payload-nulls.test.tscovers the MCP handler, andtests/transports/mcp-null-payload-stdio.test.tsdrives the packaged MCP server over stdio. Both fail without the fix and pass with it.npm run verifyis green.