ci: shorten pull request feedback - #564
Merged
Merged
Conversation
- The test step puts TEMP/TMP on the runner's temp disk. On Windows, TEMP pointed at the OS disk (C:) while the workspace and runner.temp are on D:, and the suite creates a temp folder and a SQLite database per test; the Windows legs spent 1556 s of test time against 373 s on ubuntu. Node reads TMPDIR on ubuntu and macOS, so nothing changes there. - Matrix legs no longer lint twice: verify:release already runs `npm run lint` first, in the same leg. - The ubuntu/Node 24 leg runs the suite with the coverage floor instead of a separate job running the same suite on the same OS and Node again. - The packaged dashboard e2e runs inside SDLC verify, which already ran the same command on the same OS and Node; the separate job is gone. - Tests pin that the coverage leg exists, that the coverage thresholds are not lowered, and that the verify:release, coverage, SDLC verify and temp-folder settings cannot be skipped or removed quietly.
- The comment on the test step's TEMP/TMP now says that ubuntu and macOS read TMPDIR first, and that where it is unset temp moves to runner.temp. - Tests pin that verify:release still starts with `npm run lint`, and that the matrix still includes windows-latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #563
The two Windows legs set the pace of every pull request: about 31 minutes each on run 36757693602, against 1–9 minutes for every other job. Their tests ran about four times slower than on ubuntu (1556 s against 373 s of test time), most of it in tests that create a temp folder and a SQLite database each time. On the Windows runner those temp folders were on
C:, while the workspace andrunner.tempare onD:.TEMPandTMPtorunner.temp. On ubuntu and macOS Node readsTMPDIRfirst; where it is unset, temp also moves torunner.temp.npm run verify:release, instead of twice.SDLC verify(Node 22, as before) instead of a separate job.Every OS/Node combination still runs the full suite. The speed-up is measured by this pull request's own run, not claimed in advance.
Required checks. The
Coverage floorandPackaged Dashboard E2E Smokejobs no longer exist. Their work runs inBuild & Test (ubuntu-latest, Node 24)andSDLC verify, which are already required, so those two contexts must be removed from branch protection before this can merge.