Qt: Various fixes for localisation - #14922
Open
TheLastRar wants to merge 4 commits into
Open
TheLastRar wants to merge 4 commits into
TheLastRar wants to merge 4 commits into
Conversation
Mrlinkwii
approved these changes
Sep 7, 2026
TheLastRar
marked this pull request as draft
September 7, 2026 16:30
Contributor
Author
|
Also tackles some of the easier Qt items in #9062 Also, I could alternatively embed a ISO format date/time, since that includes a timezone and thus we can convert from it without having to force git to use UTC. |
TheLastRar
marked this pull request as ready for review
September 7, 2026 20:57
Mrlinkwii
approved these changes
Sep 11, 2026
kamfretoz
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Ensure that the embedded release date is in UTC.
Translate the git release date/time to match the system local & time zone.
Move MemoryCardListItem into MemoryCardListWidget
Make the new DNS host "New Host" default text translatable (note that existing entries are saved to a file)
Correct/Add context when calling
BindWidgetToEnumSetting.Rationale behind Changes
The displayed Git release date & time should probably match the system time zone (and be localised to the system locale).
Ensuring that the embedded release datetime is in UTC ensure that time zone conversion will be correct.
In our base translation file, most of the strings in
MemoryCardListWidget.cppare under theMemoryCardListItemcontext.Moving the MemoryCardListItem into MemoryCardListWidget should hopefully resolve that once the translation action updates.
These strings will probably need to be retranslated.
The docking & anisotropic filtering options where already translatable, but the incorrect/missing context prevented us from loading those translations.
fixes #14810
Suggested Testing Steps
Test that it builds on CI.
Test translating strings.
Did you use AI to help find, test, or implement this issue or feature?
No