GS: Update dirty area in special HW local->local transfers - #14941
Merged
Merged
Conversation
refractionpcsx2
changed the title
JordanTheToaster
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updates dirty areas that overlap GS local->local transfers for special page/shuffle handling
Also adds local->local hardware transfers to the transfer dumping
Rationale behind Changes
There were conditions where there would be dirty data which later got overwritten by the local->local GS transfer. In the case of Busin 0 - Wizardry Alternative Neo it would upload an entire frame/garbage to 0x3000,. then later copy the real framebuffer to the same address, however as soon as it was used, it was updating the target from GS memory, overwriting the good newer data, which is of course incorrect.
Suggested Testing Steps
Test Busin 0 - Wizardry Alternative Neo and Dark Cloud to make sure the graphics are correct.
Did you use AI to help find, test, or implement this issue or feature?
No
Fixes the death scene in Busin 0 - Wizardry Alternative Neo and the lighting in Dark Cloud in some situations.
Busin 0 - Wizardry Alternative Neo:
Master:
PR:
Dark Cloud:
Master:
PR (This now matches software):