Normalize two-qubit noise rates to signed principal angles - #795
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct calls to
GeneralNoiseModel::p2_angle_error_ratecurrently evaluate unsigned angles using the positive coefficients and their unreduced magnitude. For example,7*pi/4gets a different rate from the equivalent-pi/4rotation.Reduce the noise-model input into
(-pi, pi]before selecting the asymmetric coefficients and applying magnitude/power scaling. Full turns use the zero-angle offset average, and both half-turn endpoints use the positive branch. Gate storage remains unchanged. The existing gate-processing path already supplies signed angles; this makes the public rate API follow the same convention.Add regression coverage for unsigned inputs, multiple turns, asymmetric coefficients, quadratic scaling, tiny signed angles, and values adjacent to the half-turn boundary. Also clarify the matching neo range and test its wrapped-angle behavior.
Validation:
cargo test --locked --offline -p pecos-engines --lib: 179 passed.cargo test --locked --offline -p pecos-neo --lib noise::two_qubit::tests: 20 passed.cargo fmt --all -- --check.cargo clippy --locked --offline -p pecos-engines -p pecos-neo --all-targets -- -D warnings.