Conversation
ciaranra
force-pushed
the
rxyxy2q-docs-and-zero-snap
branch
from
September 20, 2026 05:58
7f1e480 to
2db549d
Compare
ciaranra
force-pushed
the
rxyxy2q-docs-and-zero-snap
branch
from
September 21, 2026 03:57
2db549d to
1330bde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #805. Addresses the zero-check half of #804.
Change
try_rxyxy2qcomparedthetato exactAngle64::ZERObefore its Clifford check, whereastry_rxxsnaps within the Clifford tolerance, so athetawithin tolerance of zero combined with a non-Cliffordphiwas rejected although the gate is the identity. It now snaps first, astry_simplify_rxy1qdoes. The existing zero-theta test covers a near-zero theta too; restoring the exact comparison makes it fail.docs/user-guide/gates.mdgains anRXYXY2Qsection (definition, matrix, relation toRXX/RYY, SeleneRPPcorrespondence, stabilizer angle grid) and a Quick Reference row;gate-naming-conventions.mdandgate-angle-types.mdlist the gate alongsideRXY1Q.Not in this PR
Accepting
theta = piwithphian odd multiple ofpi/4(a Clifford that Selene's Stim simulator accepts) stays open in #804:try_simplify_rxy1qreturns a single namedGateType, so that case needs a decomposition return type and an eighth-turn snap grid, which is a design change.Verification
cargo test -p pecos-simulators --lib clifford_rotation(35 passed),cargo clippy --locked -p pecos-simulators --all-targets -- -D warnings,cargo fmt --check, andpre-commiton the changed files, all clean.Written directly by Claude Fable 5.1 in Claude Code at the maintainer's request; no Codex arm was used for this one.