Make approval counts configurable and fix async call - #22
Open
marius851000 wants to merge 1 commit into
Open
marius851000 wants to merge 1 commit into
marius851000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So...
In NotSpriteCollab, I currently set the approval count via patch to be 1 (so any approver can accept submissions)
this make such approval count configuration in the option (so I don’t need to patch my server anymore. At least not that thing)
The default option is kept as they are, no migration needed.
Also, Python warned about an un-awaited async call, which seems fairly bad. I don’t think async is ever intended to not be awaited on (thought they can be awaited later for sure)