Use system temp directory for temporary font downloads instead of $HOME - #69
Closed
Marius Storhaug (MariusStorhaug) with Copilot wants to merge 3 commits into
Closed
Use system temp directory for temporary font downloads instead of $HOME#69Marius Storhaug (MariusStorhaug) with Copilot wants to merge 3 commits into
Marius Storhaug (MariusStorhaug) with Copilot wants to merge 3 commits into
Conversation
3 tasks
Agent-Logs-Url: https://github.com/PSModule/NerdFonts/sessions/ba986d69-673e-43ba-bb07-cbeab5223dcc Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Use system temp directory for font downloads instead of $HOME
Use system temp directory for temporary font downloads instead of $HOME
May 17, 2026
Contributor
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
Marius Storhaug (MariusStorhaug)
added a commit
that referenced
this pull request
Aug 8, 2026
….1.19 (#91) NerdFonts now runs its CI and documentation builds through Process-PSModule v6.1.19, with dependency compatibility and documentation links aligned so contributors get reliable build, test, and site-generation results. ## Changed: CI and documentation builds The repository now uses the latest Process-PSModule release and builds the documentation site with Zensical. The site build remains enabled, and no contributor action is required beyond the existing workflow and documentation conventions. ## Fixed: build and test compatibility Dependency bounds, canonical documentation links, temporary download paths, and cache-fallback coverage now match the current pipeline expectations. The workflow passes only the API key it needs instead of inheriting all repository secrets. --- <details> <summary>Technical details</summary> - Updated `.github/workflows/Process-PSModule.yml` to Process-PSModule v6.1.19 and explicit `APIKey` wiring. - Updated `actions/checkout` to v7.0.1 in `Update-FontsData.yml`. - Replaced `.github/mkdocs.yml` with `.github/zensical.toml`; the site build is enabled in `.github/PSModule.yml`. - Updated `Fonts` and `Admin` dependency minimums and maximum bounds in `Install-NerdFont.ps1`. - Switched font downloads to the system temporary directory. - Replaced mocked cache-fallback behavior with a live locked-file scenario. - Added trailing slashes to canonical documentation links and added the missing contribution/documentation guidance. - Standards and framework alignment: | Changed surface | Standards checked | Framework docs checked | Result | | --- | --- | --- | --- | | `.github/workflows/**` | GitHub Actions, secret handling | Process-PSModule workflow contract | Aligned | | `.github/zensical.toml` | Documentation configuration | Process-PSModule site pipeline | Aligned | | `src/**`, `tests/**` | PowerShell dependencies, testing | Process-PSModule source/test checks | Aligned | | `README.md`, `CONTRIBUTING.md` | Documentation | Repository contribution guidance | Aligned | - Issue convergence sweep: reviewed related open work and incorporated the system temporary-directory and README documentation changes in this delivery. </details> <details> <summary>Relevant issues (or links)</summary> - PSModule/Process-PSModule#444 — wildcard `MaximumVersion` parsing was tracked upstream; current Process-PSModule releases include the upstream fix. - #69 — system temporary directory for font downloads. - #85 — README documentation link. </details> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
Marius Storhaug (MariusStorhaug)
deleted the
copilot/use-temp-directory-for-font-downloads
branch
August 8, 2026 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary download directories created by
Install-NerdFontuse$HOMEas the base path. If the command fails before cleanup runs, these directories persist in the user's home folder where no OS-level cleanup reclaims them.$HOMEto[System.IO.Path]::GetTempPath()— cross-platform .NET API resolving to$Env:TEMP(Windows) //tmp(Linux/macOS)GUID naming and
cleanblock logic unchanged.