Update Paper

[jpenilla]

Adapt checkstyle patching and preserve the Folia server logo with a dedicated folia-logo.png resource.

[electronicboy]

We shall mourn the loss of our joyous binary patch

[Dueris]

This PR updates the Paper upstream, which requires a specific set of changes in regards to this commit in Paper:

• PaperMC/Paper@2951b50

This commit, on Folia, makes it impossible for some players(often random) to connect to a Folia server, primarily in relation to packet order being screwed over during the login phase. Here are the errors that occur when this happens, I can provide stack traces too if you would like.

The image is of Discord since this was reported to me via Discord. I have already created a fix if you want to pull that or make your own, either is fine, Ive linked it below. This needs to be fixed before merging this because it can cause connectivity issues for players logging in to Folia or Folia-upstream based forks.

CraftCanvasMC/Canvas@41de6d4 - these are the changes I made to fix this.

[Spottedleaf]

dfe4091

[Dueris]

Ty for fixing that issue Spotted. However I was curious about something.

I tried initially to make the Runnable task forced to go through pendingActions(by adding false && to the if statement in the scheduleNettyTask method), and it didn't seem to work. That seems to be part of the changes you made, what was the real fix? Im just sorta curious to learn why your changes resolve the issue and such.

From what it seems, it seems that you made it so that it sends the packet first and then schedules the compression packet on the channels event loop, rather than doing both the sending of the packet and the compression packet on the event loop. Is that correct? Idk just sorta looking to learn if that makes sense.