Skip to content

Fix trader for 0.5.3 and prevent pricing items that don't fit in the slot#2238

Merged
LocalIdentity merged 7 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-trader
Jun 20, 2026
Merged

Fix trader for 0.5.3 and prevent pricing items that don't fit in the slot#2238
LocalIdentity merged 7 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-trader

Conversation

@vaisest

@vaisest vaisest commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #2236, #2237.

Description of the problem being solved:

Fixes the crashes that happen due to the 0.5.3 changes. Item results now seem to have a differently shaped explicitMods field which has the mod flags such as whether it's fractured.

Also filters item results more by checking if they fit in the slot. This is mostly relevant for manual "Price Item" searches where the user can use any search. Putting boots in the weapon slot didn't make much sense.

The mirrored tag seems to be missing from the API result. Corrupted and sanctified are still there.

Steps taken to verify a working solution:

  • Tested with various searches

Link to a build that showcases this PR:

N/A

Before screenshot:

N/A

After screenshot:

N/A

@vaisest vaisest changed the title Fix item parsing for 0.5.3 update and filter items based on slot Fix trade parsing for 0.5.3 update and filter items based on slot Jun 19, 2026
@gfsd3v

gfsd3v commented Jun 19, 2026

Copy link
Copy Markdown

will test this now, thx

edit: can confirm it works, code changes makes sense as well

image

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Jun 19, 2026
@Yeforme

Yeforme commented Jun 19, 2026

Copy link
Copy Markdown

Dumb question how does one get this fix to work with my path of building?

@DJGonzales96

Copy link
Copy Markdown

@Yeforme You would have to wait for the PR to merge and then update pushed to the app. Or, you could download the src files from Git and paste them into your POB2 install dir if you need them now.

@gfsd3v

gfsd3v commented Jun 19, 2026

Copy link
Copy Markdown

Dumb question how does one get this fix to work with my path of building?

I vibe coded a ps1 script to patch my non technical friends PoB, github doesn't allow it to share tho.... but just reading the contribute docs should give u an idea on how to build from source and switch branches

@zab-w

zab-w commented Jun 19, 2026

Copy link
Copy Markdown

This fixes trade of all items except for "Heart of the Well":
{code}
Error:

In download callback: Classes/TradeQuery.lua:1004: attempt to index upvalue 'activeSlot' (a nil value)
stack traceback:
Classes/TradeQuery.lua:1004: in function 'callback'
Classes/TradeQueryRequests.lua:263: in function 'callback'
Classes/TradeQueryRequests.lua:61: in function 'callback'
Launch.lua:315: in function Launch.lua:314
[C]: in function 'PCall'
Launch.lua:226: in function Launch.lua:218
v0.21.0 master
Press Enter/Escape to dismiss, or F5 to restart the application.
Press CTRL + C to copy error text.
{code}
It's 0.21.0 patched with changes from the PR

@vaisest

vaisest commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

This fixes trade of all items except for "Heart of the Well": {code} Error:

In download callback: Classes/TradeQuery.lua:1004: attempt to index upvalue 'activeSlot' (a nil value) stack traceback: Classes/TradeQuery.lua:1004: in function 'callback' Classes/TradeQueryRequests.lua:263: in function 'callback' Classes/TradeQueryRequests.lua:61: in function 'callback' Launch.lua:315: in function Launch.lua:314 [C]: in function 'PCall' Launch.lua:226: in function Launch.lua:218 v0.21.0 master Press Enter/Escape to dismiss, or F5 to restart the application. Press CTRL + C to copy error text. {code} It's 0.21.0 patched with changes from the PR

Oh, good catch. I really should've tested this better

@vaisest vaisest changed the title Fix trade parsing for 0.5.3 update and filter items based on slot Fix trader for 0.5.3 and prevent pricing items that don't fit in the slot Jun 19, 2026
Also fixes unique jewels being able to search for the lich socket that can't have unique jewels
Will be more relevant when we add sinister sockets
Fix socket selection logic

@LocalIdentity LocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future when fixing prominant crashes, make the PR just for that then add other stuff to a new PR so it makes it easier to review

@LocalIdentity LocalIdentity merged commit 2d09769 into PathOfBuildingCommunity:dev Jun 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to search POE trade for items

6 participants