Fix trader for 0.5.3 and prevent pricing items that don't fit in the slot#2238
Conversation
|
Dumb question how does one get this fix to work with my path of building? |
|
@Yeforme You would have to wait for the PR to merge and then update pushed to the app. Or, you could download the src files from Git and paste them into your POB2 install dir if you need them now. |
I vibe coded a ps1 script to patch my non technical friends PoB, github doesn't allow it to share tho.... but just reading the contribute docs should give u an idea on how to build from source and switch branches |
|
This fixes trade of all items except for "Heart of the Well": In download callback: Classes/TradeQuery.lua:1004: attempt to index upvalue 'activeSlot' (a nil value) |
Oh, good catch. I really should've tested this better |
Also fixes unique jewels being able to search for the lich socket that can't have unique jewels Will be more relevant when we add sinister sockets Fix socket selection logic
LocalIdentity
left a comment
There was a problem hiding this comment.
In the future when fixing prominant crashes, make the PR just for that then add other stuff to a new PR so it makes it easier to review

Fixes #2236, #2237.
Description of the problem being solved:
Fixes the crashes that happen due to the 0.5.3 changes. Item results now seem to have a differently shaped explicitMods field which has the mod flags such as whether it's fractured.
Also filters item results more by checking if they fit in the slot. This is mostly relevant for manual "Price Item" searches where the user can use any search. Putting boots in the weapon slot didn't make much sense.
The mirrored tag seems to be missing from the API result. Corrupted and sanctified are still there.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A
Before screenshot:
N/A
After screenshot:
N/A