Add achievements filters - #72
Conversation
|
Hi, I have a small issue with the UX. The sorting and filtering icons are separated by the window title, and the filtering is a button group while the sorting is a radio list. Do you think you could be able to display both the same way? I'd do it with both filtering and sorting in the same popover, in two different sections , as radio buttons. Forgive my paint. But that is only details, more importantly, your controls are at the window level, and not the achievement list level. This screen can also show the stats list. If you want to keep them here, there must be sorting/filtering options for stats too, when appropriate. The design I suggested would allow to switch between the achievement/stats tabs without having the filters pop in and out in the header bar, and to show the appropriate options in the popover. Either way, I am nowhere near being an UX guru, I would love to hear what you think about that and whether you have other ideas. Thanks!! |
|
Agree, looks kinda strange 2 similar behavior be so different, So I moved to the hamburger menu, along side already existent achievement language settings (makes sense for me). Also tested with the button like your suggestion and works fine. either way works for me. so I'll let you choose, let me know if you prefer the button. 
|
|
Sure, if it's fine for you this way I'm good with that. I've done a little of a cleanup/code review. If you're good with the changes please confirm to me, and LGTM! |
|
I just realized, your sorting and filtering choices are not persisted, you will have to choose your preference again at every app startup, let me know if that's intentional too |
|
Achievement/Stat order should be persistent now |
2 participants
Disclaimer: the code was generated by a LLM (GPT 5.6 Sol), I'm not too familiar with rust, so my review was not that good, please let me know if something needs to be improved.