Switch Zap Pusher to terminal-only response and add shared PKCS#1 enc…#131
Merged
peter-paystack merged 1 commit intoJul 10, 2026
Merged
Conversation
…ryption
Refactor the Zap listen path to the narrow Charge3DSResponse / ChargeCardTransaction
shape shared with card 3DS and mobile money, replacing the reused
PayWithTransfer shape. The server only publishes terminal success/failed
events on the Zap channel, so the ZapViewModel loop collapses to a
single-shot await per the PusherSubscriptionListener contract.
- Zap: listenForZapResponse now returns Service<Charge3DSResponse>; repository
maps to ChargeCardTransaction; ZapViewModel drops the re-subscribe loop.
- Cryptography: expose public Cryptography + CryptographyProtocol with an
encryptPKCS1 (RSA PKCS#1 v1.5) method mirroring Node's crypto.publicEncrypt.
- Add EmptyRequest Encodable model for bodyless POST endpoints.
- Add provider assets (Capitec Pay, Scan to Pay, SnapScan, SA flag) and
Pusher/response fixtures (CapitecPay, QR, Zap success/failed) as groundwork
for the Capitec Pay and Scan-to-Pay charge flows.
- Tests: PKCS#1 round-trip + non-determinism coverage, Zap success/failed
decode tests, and updated Zap repository/view-model/mock expectations.
|
vusi-paystack
approved these changes
Jul 10, 2026
peter-paystack
deleted the
feature/Switch-Zap-Pusher-to-terminal-only-response
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ryption
Refactor the Zap listen path to the narrow Charge3DSResponse / ChargeCardTransaction
shape shared with card 3DS and mobile money, replacing the reused
PayWithTransfer shape. The server only publishes terminal success/failed
events on the Zap channel, so the ZapViewModel loop collapses to a
single-shot await per the PusherSubscriptionListener contract.