feat: load pexels url from env var#87
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces a hardcoded Pexels “featured uploads” URL with a value read from an environment variable, and reuses that same configuration in both the CLI script entrypoint and the Lambda handler.
Changes:
- Added
getPexelsFeaturedUploadsUrl()to readPEXELS_FEATURED_UPLOADS_URLfromprocess.env. - Updated
main()to use the env-provided URL instead of an inline constant. - Updated
lambda-handler.tsto use the shared URL getter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/src/main.ts | Introduces env-based Pexels URL getter and uses it in the CLI entrypoint; exports the getter. |
| scripts/src/lambda-handler.ts | Switches Lambda to use the shared env-based Pexels URL getter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
26
to
29
| try { | ||
| const pexelsUrl = | ||
| "https://www.pexels.com/@perry-z-1662054943/featured-uploads/"; | ||
| const pexelsUrl = getPexelsFeaturedUploadsUrl(); | ||
| console.log(`Fetching images from: ${pexelsUrl}`); | ||
| const imageLinks = await getImageLinksPlaywright(pexelsUrl); |
Comment on lines
+10
to
+20
| function getPexelsFeaturedUploadsUrl(): string { | ||
| const pexelsUrl = process.env[PEXELS_FEATURED_UPLOADS_URL_ENV]?.trim(); | ||
|
|
||
| if (!pexelsUrl) { | ||
| throw new Error( | ||
| `${PEXELS_FEATURED_UPLOADS_URL_ENV} environment variable is required`, | ||
| ); | ||
| } | ||
|
|
||
| return pexelsUrl; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.