Skip to content

ci(prow): migrate pingcap/tiflow release-7.5 jobs to target jenkins - #5142

Open
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/pingcap-tiflow-release-7.5
Open

ci(prow): migrate pingcap/tiflow release-7.5 jobs to target jenkins#5142
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/pingcap-tiflow-release-7.5

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Part of #4960.

Summary

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/pingcap/tiflow/release-7.5-presubmits.yaml so they are scheduled on the to Jenkins.

Part of #4947 / #4942

@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wuhuizuo for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR migrates pingcap/tiflow release-7.5 presubmit Jenkins jobs to a new Jenkins target by flipping the labels.master value from "1" to "0" in the release-7.5-presubmits.yaml configuration file. The approach is a straightforward label update for all relevant jobs, which appears consistent and correctly scoped. The changes are simple and low risk, improving CI job targeting without introducing new logic.


Code Improvements

  • Centralize the label value for easier future updates
    Currently, the change is done by manually updating each job’s labels.master value from "1" to "0" inline. If this pattern repeats across other releases or repos, it might be better to define a reusable anchor or variable for the label value to reduce duplication and potential errors. For example, use YAML anchors or a common label definition to toggle between "1" and "0" easily.

    File: prow-jobs/pingcap/tiflow/release-7.5-presubmits.yaml
    Lines: All changed label lines (~10-100)
    Suggestion:

    label_master_new: &label_master_new "0"
    
    presubmits:
      - name: ...
        labels:
          master: *label_master_new
  • Add a comment explaining the significance of label flip
    The PR description explains the reason for changing labels.master from "1" to "0" (to target a different Jenkins agent). Adding a brief comment in the YAML near the label change would help future maintainers understand why "0" is used instead of "1".

    File: prow-jobs/pingcap/tiflow/release-7.5-presubmits.yaml
    Line: Near the first labels.master change, e.g., line 12
    Suggestion:

    labels:
      master: "0"  # Switch to new Jenkins agent; "1" was the old agent

Best Practices

  • Testing and Validation
    Given these are CI job configuration files, ensure there is a test or validation step that confirms the jobs are correctly scheduled on the intended Jenkins agents after this change. This could be mentioned in the PR or ensured via CI tooling.

  • Documentation
    The PR description references related issues and the purpose, which is good. Consider updating any external documentation that describes the Jenkins agent usage or job routing policies to reflect this change.


No critical issues or bugs were identified given the straightforward nature of the change. Overall, the PR is clear and focused; incorporating the above suggestions would improve maintainability and clarity.

@ti-chi-bot

ti-chi-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Jenkins Migration Verification

Migrating jenkins-agent Prow jobs to the to Jenkins (labels.master: 1 -> 0).

  • pingcap/tiflow/release-7.5/pull_cdc_integration_kafka_test
    • status: infra-fail
  • pingcap/tiflow/release-7.5/pull_cdc_integration_mysql_test
    • status: failed
  • pingcap/tiflow/release-7.5/pull_cdc_integration_storage_test
    • status: infra-fail

Summary: success=0 submitted=0 failed=1 infra-fail=2 skipped=0 dry-run=0 total=3

@ti-chi-bot ti-chi-bot Bot added the size/S label Sep 4, 2026
wuhuizuo added a commit that referenced this pull request Sep 4, 2026
…jenkins

Split from #5142: jobs verified SUCCESS on the to Jenkins in
pull-verify-jenkins-migration runid 2095811541558366208. Flip their labels.master.

Part of #4960
wuhuizuo added a commit that referenced this pull request Sep 4, 2026
…jenkins (#5165)

Split from #5142 — only the jobs that verified **SUCCESS** on the to
Jenkins (verify runid 2095811541558366208):
- `ghpr_verify`
- `pull_cdc_integration_pulsar_test`
- `pull_dm_compatibility_test`
- `pull_dm_integration_test`
Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/pingcap/tiflow/release-7.5-presubmits.yaml so
they are scheduled on the to Jenkins.

Part of #4960
@wuhuizuo
wuhuizuo force-pushed the phase4/pingcap-tiflow-release-7.5 branch from bb36649 to a71e3b9 Compare September 7, 2026 03:18

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR migrates several jenkins-agent jobs in the pingcap/tiflow/release-7.5-presubmits.yaml file from the old Jenkins setup (master: "1") to the new target Jenkins (master: "0"). The approach is straightforward, simply flipping the label values for these jobs to affect scheduling. The changes are minimal and focused, and the overall quality is good with clear intent.


Code Improvements

  • Clarify the meaning of master label values

    • File: prow-jobs/pingcap/tiflow/release-7.5-presubmits.yaml (lines ~10, 23, 49)
    • Issue: The label key master with values "1" or "0" is not self-explanatory and may confuse future maintainers.
    • Suggestion: Add a comment explaining what master: "0" and master: "1" mean regarding Jenkins scheduling or consider renaming the label to something more descriptive like jenkins-target or jenkins-master with clear documentation. For example:
      labels:
        # 'master: "0"' means schedule on the new Jenkins instance; '1' is the old Jenkins
        master: "0"
  • Consistency in comments

    • The comment # need add this. after decorate: false is unclear and grammatically incorrect.
    • Suggest rephrasing to clarify intent, e.g., # decorate must be explicitly set to false for these jobs.

Best Practices

  • Documentation on migration status

    • Since this PR is part of a larger migration effort (#4960, #4947, #4942), it would be helpful to add a top-level comment or annotation in the YAML file or a linked README documenting the status of Jenkins migration for this release branch and any known caveats.
  • Testing/Validation

    • Ensure that there is a process to verify that the jobs are indeed scheduled on the target Jenkins after this label change. If not already in place, consider adding a note or automation to confirm effective migration.

Summary of Action Items:

labels:
  # 'master: "0"' means schedule on the new Jenkins instance; '1' is the old Jenkins
  master: "0"  # updated to switch to target Jenkins
decorate: false  # decorate must be explicitly set to false for these jobs
  • Add clarifying comments for master label usage.
  • Improve comment clarity on decorate: false.
  • Consider documenting the Jenkins migration status in the repo.
  • Verify that jobs run on the intended Jenkins after migration.

@ti-chi-bot ti-chi-bot Bot added size/XS and removed size/S labels Sep 7, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify-jenkins-migration a71e3b9 link true /test pull-verify-jenkins-migration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants