ci(prow): migrate pingcap/tiflash release-6.5 jobs to target jenkins - #5146
ci(prow): migrate pingcap/tiflash release-6.5 jobs to target jenkins#5146wuhuizuo wants to merge 1 commit into
Conversation
Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/pingcap/tiflash/release-6.5-presubmits.yaml so they are scheduled on the to Jenkins. Part of #4962
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
I have already done a preliminary review for you, and I hope to help you do a better job.
Summary
This PR updates the prow-jobs/pingcap/tiflash/release-6.5-presubmits.yaml file by flipping the labels.master value from "1" to "0" for two Jenkins-agent jobs, effectively migrating their execution to a new Jenkins target. The change is minimal and focused, with clear intent and proper context referencing related issues. The YAML modification is straightforward and syntactically correct.
Code Improvements
-
Clarify
labels.mastermeaning:- File:
prow-jobs/pingcap/tiflash/release-6.5-presubmits.yamllines 10-15 and 23-28 - Issue: The significance of
"1"vs"0"inlabels.masteris not self-evident from the YAML snippet. This can cause confusion for future maintainers. - Suggestion: Add a comment near the label to explain what
"0"and"1"represent, e.g.:labels: master: "0" # '0' schedules on the new Jenkins target; '1' was the old one
- File:
-
Consistent comment style:
- The comment
# need add this.is grammatically awkward and repeated twice. - Suggest rephrasing to clearer English, e.g.:
decorate: false # must be set to false for Jenkins-agent jobs
- The comment
Best Practices
-
Testing or validation mention:
- Since this change affects CI job scheduling, it would be beneficial to mention or link to any tests or validation steps confirming that jobs are correctly routed to the new Jenkins target.
- If none exist, consider adding a sanity check or documenting manual validation steps in the PR description.
-
PR description improvement:
- The PR description could benefit from a brief explanation about what
labels.mastercontrols and why"0"is the target for the new Jenkins instance. This will help reviewers and future readers understand the context without digging into other issues.
- The PR description could benefit from a brief explanation about what
No critical issues found given the scope of the change. The PR is concise and focused on a specific migration step.
Jenkins Migration VerificationMigrating jenkins-agent Prow jobs to the to Jenkins (
Summary: success=1 submitted=0 failed=1 infra-fail=0 skipped=0 dry-run=0 total=2 |
|
@wuhuizuo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…t jenkins (#5160) Split from #5146 (only the verified-successful job). ## Evidence - Migration verify for #5146 (run `pull-verify-jenkins-migration`) shows: - `pingcap/tiflash/release-6.5/pull_unit_test` => **SUCCESS** on the to Jenkins - `pull_integration_test` => FAILURE (not migrated here) - Flip `labels.master` `"1"` -> `"0"` for `pull_unit_test` only. Part of #4962 / #4947 / #4942.
Part of #4962.
Summary
Flip
labels.master"1"->"0"for the jenkins-agent jobs inprow-jobs/pingcap/tiflash/release-6.5-presubmits.yamlso they are scheduled on the to Jenkins.Part of #4947 / #4942