Skip to content

ci(prow): migrate pingcap/tiflash release-6.5 jobs to target jenkins - #5146

Open
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/pingcap-tiflash-release-6.5
Open

ci(prow): migrate pingcap/tiflash release-6.5 jobs to target jenkins#5146
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/pingcap-tiflash-release-6.5

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Part of #4962.

Summary

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/pingcap/tiflash/release-6.5-presubmits.yaml so they are scheduled on the to Jenkins.

Part of #4947 / #4942

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/pingcap/tiflash/release-6.5-presubmits.yaml so
they are scheduled on the to Jenkins.

Part of #4962
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lloyd-pottiger for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR updates the prow-jobs/pingcap/tiflash/release-6.5-presubmits.yaml file by flipping the labels.master value from "1" to "0" for two Jenkins-agent jobs, effectively migrating their execution to a new Jenkins target. The change is minimal and focused, with clear intent and proper context referencing related issues. The YAML modification is straightforward and syntactically correct.


Code Improvements

  • Clarify labels.master meaning:

    • File: prow-jobs/pingcap/tiflash/release-6.5-presubmits.yaml lines 10-15 and 23-28
    • Issue: The significance of "1" vs "0" in labels.master is not self-evident from the YAML snippet. This can cause confusion for future maintainers.
    • Suggestion: Add a comment near the label to explain what "0" and "1" represent, e.g.:
      labels:
        master: "0" # '0' schedules on the new Jenkins target; '1' was the old one
  • Consistent comment style:

    • The comment # need add this. is grammatically awkward and repeated twice.
    • Suggest rephrasing to clearer English, e.g.:
      decorate: false # must be set to false for Jenkins-agent jobs

Best Practices

  • Testing or validation mention:

    • Since this change affects CI job scheduling, it would be beneficial to mention or link to any tests or validation steps confirming that jobs are correctly routed to the new Jenkins target.
    • If none exist, consider adding a sanity check or documenting manual validation steps in the PR description.
  • PR description improvement:

    • The PR description could benefit from a brief explanation about what labels.master controls and why "0" is the target for the new Jenkins instance. This will help reviewers and future readers understand the context without digging into other issues.

No critical issues found given the scope of the change. The PR is concise and focused on a specific migration step.

@ti-chi-bot ti-chi-bot Bot added the size/XS label Sep 4, 2026
@ti-chi-bot

ti-chi-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Jenkins Migration Verification

Migrating jenkins-agent Prow jobs to the to Jenkins (labels.master: 1 -> 0).

  • pingcap/tiflash/release-6.5/pull_unit_test
    • status: success
  • pingcap/tiflash/release-6.5/pull_integration_test
    • status: failed

Summary: success=1 submitted=0 failed=1 infra-fail=0 skipped=0 dry-run=0 total=2

@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify-jenkins-migration fc571e8 link true /test pull-verify-jenkins-migration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

wuhuizuo added a commit that referenced this pull request Sep 4, 2026
…t jenkins

Split from #5146: only pull_unit_test verified SUCCESS on the to Jenkins
(pull_integration_test still fails). Flip its labels.master "1" -> "0".

Part of #4962
wuhuizuo added a commit that referenced this pull request Sep 4, 2026
…t jenkins (#5160)

Split from #5146 (only the verified-successful job).

## Evidence
- Migration verify for #5146 (run `pull-verify-jenkins-migration`)
shows:
- `pingcap/tiflash/release-6.5/pull_unit_test` => **SUCCESS** on the to
Jenkins
  - `pull_integration_test` => FAILURE (not migrated here)
- Flip `labels.master` `"1"` -> `"0"` for `pull_unit_test` only.

Part of #4962 / #4947 / #4942.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants