ci(prow): migrate pingcap/tiflash release-7.1 jobs to target jenkins

[wuhuizuo]

Part of #4962.

Summary

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/pingcap/tiflash/release-7.1-presubmits.yaml so they are scheduled on the to Jenkins.

Part of #4947 / #4942

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jayson-huang for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• prow-jobs/pingcap/tiflash/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR updates the prow-jobs/pingcap/tiflash/release-7.1-presubmits.yaml file to migrate specific Jenkins agent jobs from one Jenkins instance to another by changing the labels.master value from "1" to "0". The change is minimal and targeted, focusing only on flipping the labels to redirect job scheduling. The implementation is straightforward and clear.

---

Code Improvements

• Clarify the meaning of the master label and its values

  • File: prow-jobs/pingcap/tiflash/release-7.1-presubmits.yaml (lines 11 and 24)
  • Issue: The label key master with values "1" or "0" is not self-explanatory. It's unclear what "0" or "1" signify without external context, which could cause confusion for future maintainers.
  • Suggestion: Add a comment above the labels section explaining the significance of the master label and what "0" and "1" represent, for example:

    # 'master' label controls Jenkins instance routing: "1" for old Jenkins, "0" for target Jenkins.
    labels:
      master: "0"

• Consider use of constants or variables for label values

  • File: prow-jobs/pingcap/tiflash/release-7.1-presubmits.yaml
  • Issue: Hardcoding "0" and "1" is error-prone and not descriptive. Using a named constant or variable for the label values would improve readability and maintainability.
  • Suggestion: If the prow job YAML supports anchors or variables, define the label values with meaningful names, e.g.:

    labels:
      master: &jenkins_target "0"

    Then reference *jenkins_target where needed.

---

Best Practices

• Add a changelog or migration note

  • File: PR description or a suitable documentation file
  • Issue: Since this PR affects CI job routing for a release branch, documenting this migration in a changelog or internal migration guide would help other developers and operators track this change and avoid confusion if jobs stop running as expected.
  • Suggestion: Add a brief note in the PR description or a dedicated docs file about why this change was made and what downstream effects to expect.

• Testing and validation

  • File: N/A (YAML configuration)
  • Issue: It's not obvious if this label flip has been validated to correctly schedule jobs on the new Jenkins instance.
  • Suggestion: Ensure CI job triggers have been tested on the target Jenkins. Add a note in the PR description confirming that jobs run successfully post-migration or reference a test plan.

---

No critical issues or broken functionality identified given this limited scope change. Overall, the PR is clean and focused but would benefit from improved documentation and clarity on label semantics.

[ti-chi-bot]

Jenkins Migration Verification

Migrating jenkins-agent Prow jobs to the to Jenkins (labels.master: 1 -> 0).

• pingcap/tiflash/release-7.1/pull_unit_test
  • status: failed
• pingcap/tiflash/release-7.1/pull_integration_test
  • status: failed

Summary: success=0 submitted=0 failed=2 infra-fail=0 skipped=0 dry-run=0 total=2

[ti-chi-bot]

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-verify-jenkins-migration	6077c3e	link	true	/test pull-verify-jenkins-migration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.