ci(prow): migrate pingcap/tiflash release-7.5 jobs to target jenkins - #5148
ci(prow): migrate pingcap/tiflash release-7.5 jobs to target jenkins#5148wuhuizuo wants to merge 1 commit into
Conversation
Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/pingcap/tiflash/release-7.5-presubmits.yaml so they are scheduled on the to Jenkins. Part of #4962
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:
This PR updates the release-7.5-presubmits.yaml configuration for pingcap/tiflash by flipping the labels.master value from "1" to "0" for Jenkins agent jobs. This change effectively migrates the presubmit jobs to run on the target Jenkins infrastructure as part of ongoing CI migration efforts. The change is straightforward and limited in scope, making it low risk and easy to verify.
Code Improvements
-
Clarify the meaning of the
masterlabel:- File:
prow-jobs/pingcap/tiflash/release-7.5-presubmits.yaml(lines ~11 and ~24) - Issue: The label key
masterwith values"1"or"0"is not self-explanatory. Without documentation, it can be confusing for future maintainers to understand what this flag controls. - Suggestion: Add a comment before the jobs or near the label usage explaining what
master: "0"means (e.g., "Indicates to schedule job on target Jenkins instead of legacy Jenkins"). This improves maintainability and clarity. For example:# 'master: "0"' indicates that this job should run on the target Jenkins system. labels: master: "0"
- File:
-
Verify if other similar jobs need the same update:
- The PR changes only two jobs under
release-7.5-presubmits.yaml. Confirm if other jobs in this or sibling files should also be migrated to keep consistency. If so, consider a bulk update or note why only these two are targeted.
- The PR changes only two jobs under
Best Practices
-
Testing and Validation:
- Since this is a CI configuration change, ensure that the jobs actually run on the intended Jenkins instance after this label flip. If possible, add or reference any tests or validation steps that confirm the migration success.
-
Documentation:
- If there is a project-level or team-level document describing the Jenkins migration, link to it in the PR description or add a comment in the YAML file to help future developers understand the context.
No critical issues or broken functionality were found given the limited and straightforward nature of the change. The PR is well-scoped and focused on a single migration step.
Jenkins Migration VerificationMigrating jenkins-agent Prow jobs to the to Jenkins (
Summary: success=0 submitted=0 failed=2 infra-fail=0 skipped=0 dry-run=0 total=2 |
|
@wuhuizuo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Part of #4962.
Summary
Flip
labels.master"1"->"0"for the jenkins-agent jobs inprow-jobs/pingcap/tiflash/release-7.5-presubmits.yamlso they are scheduled on the to Jenkins.Part of #4947 / #4942