Skip to content

ci(prow): migrate pingcap/tiflash release-7.5 jobs to target jenkins - #5148

Open
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/pingcap-tiflash-release-7.5
Open

ci(prow): migrate pingcap/tiflash release-7.5 jobs to target jenkins#5148
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/pingcap-tiflash-release-7.5

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Part of #4962.

Summary

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/pingcap/tiflash/release-7.5-presubmits.yaml so they are scheduled on the to Jenkins.

Part of #4947 / #4942

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/pingcap/tiflash/release-7.5-presubmits.yaml so
they are scheduled on the to Jenkins.

Part of #4962
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jayson-huang for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary:
This PR updates the release-7.5-presubmits.yaml configuration for pingcap/tiflash by flipping the labels.master value from "1" to "0" for Jenkins agent jobs. This change effectively migrates the presubmit jobs to run on the target Jenkins infrastructure as part of ongoing CI migration efforts. The change is straightforward and limited in scope, making it low risk and easy to verify.


Code Improvements

  • Clarify the meaning of the master label:

    • File: prow-jobs/pingcap/tiflash/release-7.5-presubmits.yaml (lines ~11 and ~24)
    • Issue: The label key master with values "1" or "0" is not self-explanatory. Without documentation, it can be confusing for future maintainers to understand what this flag controls.
    • Suggestion: Add a comment before the jobs or near the label usage explaining what master: "0" means (e.g., "Indicates to schedule job on target Jenkins instead of legacy Jenkins"). This improves maintainability and clarity. For example:
      # 'master: "0"' indicates that this job should run on the target Jenkins system.
      labels:
        master: "0"
  • Verify if other similar jobs need the same update:

    • The PR changes only two jobs under release-7.5-presubmits.yaml. Confirm if other jobs in this or sibling files should also be migrated to keep consistency. If so, consider a bulk update or note why only these two are targeted.

Best Practices

  • Testing and Validation:

    • Since this is a CI configuration change, ensure that the jobs actually run on the intended Jenkins instance after this label flip. If possible, add or reference any tests or validation steps that confirm the migration success.
  • Documentation:

    • If there is a project-level or team-level document describing the Jenkins migration, link to it in the PR description or add a comment in the YAML file to help future developers understand the context.

No critical issues or broken functionality were found given the limited and straightforward nature of the change. The PR is well-scoped and focused on a single migration step.

@ti-chi-bot ti-chi-bot Bot added the size/XS label Sep 4, 2026
@ti-chi-bot

ti-chi-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Jenkins Migration Verification

Migrating jenkins-agent Prow jobs to the to Jenkins (labels.master: 1 -> 0).

  • pingcap/tiflash/release-7.5/pull_unit_test
    • status: failed
  • pingcap/tiflash/release-7.5/pull_integration_test
    • status: failed

Summary: success=0 submitted=0 failed=2 infra-fail=0 skipped=0 dry-run=0 total=2

@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify-jenkins-migration 9835078 link true /test pull-verify-jenkins-migration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants