ci(prow): migrate tikv/tikv release-6.5 jobs to target jenkins - #5153
ci(prow): migrate tikv/tikv release-6.5 jobs to target jenkins#5153wuhuizuo wants to merge 1 commit into
Conversation
Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/tikv/tikv/release-6.5-presubmits.yaml so they are scheduled on the to Jenkins. Part of #4964
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
I have already done a preliminary review for you, and I hope to help you do a better job.
Summary
This PR updates the Prow job configurations for the tikv/tikv repository on the release-6.5 branch by flipping the labels.master value from "1" to "0" for Jenkins agent jobs. This effectively migrates those jobs from the old Jenkins instance to the target Jenkins environment. The changes are minimal, focused, and correctly applied to relevant job definitions. Overall, the PR is straightforward and appears correct for its intended purpose.
Code Improvements
-
Clarify the
masterlabel semantics
File:prow-jobs/tikv/tikv/release-6.5-presubmits.yaml(lines ~11 and ~22)
The label keymasterwith values"1"or"0"is not self-explanatory. Consider adding a comment explaining what the label controls (e.g., routing to old or new Jenkins). This will help future maintainers understand the impact of toggling this flag. For example:labels: # master: "0" schedules this job on the target Jenkins instance; "1" routes to the legacy Jenkins. master: "0"
-
Consistent comment style and clarity
The commentdecorate: false # need add this.is slightly unclear and has a grammar issue. Consider rephrasing to something like:decorate: false # Required for Jenkins agent jobs
Best Practices
-
Testing / Validation
Since this change affects CI job routing, it’s recommended to:- Ensure that these jobs run successfully on the target Jenkins after this migration before fully deprecating the old Jenkins jobs.
- Add a note in the PR description or commit message about any manual validation or planned monitoring.
-
Documentation update
If there is any central documentation about CI job routing or how to configurelabels.master, it should be updated or linked in the PR description for completeness.
No critical issues found. The PR is concise and makes the intended configuration change correctly. Adding a bit more context in comments and ensuring validation will further improve maintainability and confidence.
Jenkins Migration VerificationMigrating jenkins-agent Prow jobs to the to Jenkins (
Summary: success=0 submitted=0 failed=2 infra-fail=0 skipped=0 dry-run=0 total=2 |
|
@wuhuizuo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Part of #4964.
Summary
Flip
labels.master"1"->"0"for the jenkins-agent jobs inprow-jobs/tikv/tikv/release-6.5-presubmits.yamlso they are scheduled on the to Jenkins.Part of #4947 / #4942