Skip to content

ci(prow): migrate tikv/tikv release-7.1 jobs to target jenkins - #5154

Open
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/tikv-tikv-release-7.1
Open

ci(prow): migrate tikv/tikv release-7.1 jobs to target jenkins#5154
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/tikv-tikv-release-7.1

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Part of #4964.

Summary

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/tikv/tikv/release-7.1-presubmits.yaml so they are scheduled on the to Jenkins.

Part of #4947 / #4942

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/tikv/tikv/release-7.1-presubmits.yaml so
they are scheduled on the to Jenkins.

Part of #4964
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dillon-zheng for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR updates the prow-jobs/tikv/tikv/release-7.1-presubmits.yaml configuration to migrate Jenkins jobs from the old Jenkins instance (master: "1") to the target Jenkins (master: "0"). The approach is straightforward—flipping the master label for two jobs. The change is small, focused, and correctly scoped, making it low risk and easy to verify.


Code Improvements

  • Clarify the meaning of the master label

    • File: prow-jobs/tikv/tikv/release-7.1-presubmits.yaml lines ~10 and ~21
    • Issue: The label master with values "1" or "0" is a bit ambiguous without context. It may be unclear for future maintainers why "0" means "target Jenkins" and "1" means "old Jenkins".
    • Suggestion: Add a brief comment above these labels explaining the significance of the master label values, e.g.:
      # 'master: "0"' schedules job on the target Jenkins, 'master: "1"' on the old Jenkins
      labels:
        master: "0"
  • Consistency in comments

    • The comment # need add this. for decorate: false is slightly ungrammatical and unclear. Consider rephrasing for clarity, e.g.:
      decorate: false # required for Jenkins jobs

Best Practices

  • Testing and validation

    • Since this is a CI configuration change affecting job scheduling, ensure there is a way to validate that these jobs are correctly picked up by the target Jenkins and do not run on the old Jenkins. Confirm if any test or dry-run process exists for prow job YAML changes and mention it in the PR description or commit message.
  • Documentation

    • The PR description could briefly mention what the impact of flipping the master label is on job scheduling (e.g., how it affects the CI pipeline). This would help reviewers and future maintainers understand the change without referencing external issues.

No critical issues or broken functionality identified given the scoped nature of this change. The PR is straightforward and low risk.

@ti-chi-bot

ti-chi-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Jenkins Migration Verification

Migrating jenkins-agent Prow jobs to the to Jenkins (labels.master: 1 -> 0).

  • tikv/tikv/release-7.1/pull_unit_test
    • status: failed
  • tikv/tikv/release-7.1/pull_integration_test
    • status: failed

Summary: success=0 submitted=0 failed=2 infra-fail=0 skipped=0 dry-run=0 total=2

@ti-chi-bot ti-chi-bot Bot added the size/XS label Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify-jenkins-migration 6555110 link true /test pull-verify-jenkins-migration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants