Skip to content

ci(prow): migrate tikv/tikv release-7.5 verified jobs to target jenkins - #5166

Merged
wuhuizuo merged 1 commit into
mainfrom
phase4-split/tikv-tikv-release-7.5-verified
Sep 4, 2026
Merged

ci(prow): migrate tikv/tikv release-7.5 verified jobs to target jenkins#5166
wuhuizuo merged 1 commit into
mainfrom
phase4-split/tikv-tikv-release-7.5-verified

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Split from #5155 — only the jobs that verified SUCCESS on the to Jenkins (verify runid 2095812213846577152):

  • pull_unit_test

Split from #5155: jobs verified SUCCESS on the to Jenkins in
pull-verify-jenkins-migration runid 2095812213846577152. Flip their labels.master.

Part of #4964

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR migrates the pull_unit_test job within the tikv/tikv/release-7.5-presubmits.yaml from the old Jenkins setup (indicated by master: "1") to the target Jenkins (master: "0"). The change is minimal, flipping a label value to redirect the job. The approach is straightforward, and the diff is small, making it easy to review. Overall, the change is clear and focused.


Code Improvements

  • Label naming clarity and documentation

    • File: prow-jobs/tikv/tikv/release-7.5-presubmits.yaml line 13-16
    • Issue: The label key master with values "1" and "0" is unclear in intent. It would be better to have descriptive label names or comments explaining what master: "1" vs master: "0" signifies (e.g., old Jenkins vs new Jenkins agent).
    • Suggestion: Add a comment or rename the label key to something more meaningful, for example:
      labels:
        jenkins-agent: "target" # "target" for new Jenkins, "legacy" for old Jenkins
      or at minimum add a comment:
      labels:
        master: "0" # "0" means use the target Jenkins agent, "1" means old Jenkins
  • decorate: false comment clarity

    • File: same as above, line 15
    • Issue: The comment # need add this. is unclear and grammatically incorrect. It does not explain why decorate: false is set.
    • Suggestion: Improve the comment to explain the rationale, e.g.:
      decorate: false # Required because this job does not support decoration yet

Best Practices

  • Testing and Verification

    • PR description mentions that this job was verified with a specific run ID. It would be beneficial to include this context as a comment near the changed label for future maintainers.
    • Suggestion: Add a comment like:
      # Migrated to target Jenkins after successful verification (runid: 2095812213846577152)
  • YAML formatting

    • The YAML looks well-formatted; no issues found.

No critical issues found given the scope of this change. The main improvements are around clarity and maintainability.

@ti-chi-bot ti-chi-bot Bot added the size/XS label Sep 4, 2026
@ti-chi-bot

Copy link
Copy Markdown
Collaborator

Jenkins Migration Verification

Migrating jenkins-agent Prow jobs to the to Jenkins (labels.master: 1 -> 0).

  • tikv/tikv/release-7.5/pull_unit_test
    • status: pending

Summary: success=0 submitted=0 failed=0 infra-fail=0 skipped=0 dry-run=0 total=1

@wuhuizuo

wuhuizuo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Merging per split-rule: every job flipped here verified SUCCESS on the to Jenkins in the referenced #514x-parent verify run (see PR body). Remaining jobs of the parent stay on the from Jenkins for now.

@wuhuizuo

wuhuizuo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@wuhuizuo
wuhuizuo merged commit 87d2cff into main Sep 4, 2026
4 of 9 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the phase4-split/tikv-tikv-release-7.5-verified branch September 4, 2026 10:56
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants