Skip to content

Move GuiWindows to the mods folder - #3331

Open
Wunka wants to merge 4 commits into
PixelGuys:masterfrom
Wunka:moveGuiWindows
Open

Move GuiWindows to the mods folder#3331
Wunka wants to merge 4 commits into
PixelGuys:masterfrom
Wunka:moveGuiWindows

Conversation

@Wunka

@Wunka Wunka commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #1537

@Wunka Wunka moved this to High Priority in PRs to review Jul 5, 2026
@Wunka

Wunka commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

High Priority so there are no changes to any GuiWindow before this gets merged

@IntegratedQuantum IntegratedQuantum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally mods shouldn't be allowed to use c stuff. Please make a separate PR that removes c from all windows.

@IntegratedQuantum IntegratedQuantum moved this from High Priority to WIP/not ready for review in PRs to review Jul 5, 2026
@Wunka

Wunka commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Ideally mods shouldn't be allowed to use c stuff. Please make a separate PR that removes c from all windows.

How else? Should we provide wrapper functions for those needed in graphics.zig?
From #3039 (comment) I understand you wouldn't like it if I just made c pub in graphics.zig

@IntegratedQuantum

Copy link
Copy Markdown
Member

Should we provide wrapper functions for those needed in graphics.zig?

Ideally yes.
I think the only thing that it's needed for it to draw a line graph, and this should probably be turned into a function in graphics.draw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: WIP/not ready for review

Development

Successfully merging this pull request may close these issues.

[MODS] Load UI windows from mods

2 participants