Add biome-specific ocean height and relative ocean height - #3427
Open
MrPiedPiper wants to merge 5 commits into
Open
Add biome-specific ocean height and relative ocean height#3427MrPiedPiper wants to merge 5 commits into
MrPiedPiper wants to merge 5 commits into
Conversation
Author
|
Known issue: if an ocean is 128+ blocks above a surface block the ocean can be cut-off by a cave biome (e.g. sky). I figure I can/should make that a separate change. |
Author
|
Should close #570 |
Author
…he z position and the surface block
Author
|
Apparently that did not in-fact fix walls not forming right... I'll get that fixed up. |
Member
Author
Member
Yes. Ideally all points on the map, instead of indexing the biome directly should index a palette of biomes, which could contain the base height of the biome and its biome seed (#431). If you want to go for this, I'd suggest to make a separate PR for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Changes:
oceanHeight,liquidBlock,isOceanRelative,relativeOceanGap, andrelativeOceanOffset.Ocean features:
relativeOceanGap, with offsets available usingrelativeOceanOffset. This is best used for small pools, as happening to aligning with biome height for deeper oceans is not likely.isOceanRelativePerformance:
I tested performance on master vs this update in 5 different newly generated worlds.
I started each world, waiting until generation finished, and noted the average time.
Master:
Seeds 0, 1, 2, 3 and 4 average time: 468451.1438742311
This update:
Seeds 0, 1, 2, 3 and 4 average time: 472425.7381765770
0.85% added time to generation
This update with more extreme settings applied to all biomes for a stress-test (
oceanHeight20,isOceanRelativetrue,relativeOceanGap3,relativeOceanOffset7)Seeds 0, 1, 2, 3 and 4 average time: 542972.4462500415
15.91% added time to generation
Code used for benchmarks copied from BoringOrng here:
This was placed into the top of
TerrainGenerator.zig'sgeneratefunction.