Add Gateway-managed shared catalog cell reconciliation - #1187
Merged
Merged
Conversation
bill-ph
approved these changes
Sep 14, 2026
bill-ph
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the Gateway-managed shared-catalog reconciliation flow, lifecycle ownership/fencing, paused compatibility mode, target certification, route/process identity checks, guarded provisioning endpoints, strict transport, and the associated red/green test coverage. I found no P0 blockers requiring code changes. The required validation workflows are still in progress, including the isolated shared-mode end-to-end and candidate-image gates called out in the PR description.
Robo Bill
benben
force-pushed
the
feat/trino-managed-shared-catalog-rollout
branch
from
September 14, 2026 15:51
93f0658 to
a43b34d
Compare
benben
marked this pull request as ready for review
September 14, 2026 15:51
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opt-in shared catalog management for registered Trino blue/green cells. Legacy/static cells remain unchanged.
Stack / merge order
Readiness prerequisite #1184 is merged. This branch is rebased onto current main and contains only its seven intended dependency/runtime commits, without duplicating the merged readiness change. It still includes and depends on #1186 lifecycle/strict-transport commits. Merge #1186 first; this branch will then be rebased to remove that dependency from its diff. Endpoint and runtime changes are independently reviewed.
Validation
Red/green ownership and transport regressions; full Kubernetes control-plane suite; PostgreSQL admission-history tests; targeted 10,000 existing-catalog no-DDL test; repository lint. Actual isolated Gateway/Trino shared-mode end-to-end lane and candidate image verification remain explicit completion gates. The retained optional suite is in #1188.
Safety / activation
Default off. No environment activation or customer changes. Remote FAILED is not a DDL completion fence and retains ownership. Existing authentication projections continue while a catalog owner is held. One-time paused compatibility rollout and private dedicated canaries are required before activation; see the runbook. Admin query observers/usage collectors still use static selections and remain a separate follow-up.