Skip to content

fix: discover mounted Trino authentication provider paths - #1204

Merged
bill-ph merged 1 commit into
mainfrom
codex/trino-auth-config-paths
Sep 18, 2026
Merged

bill-ph merged 1 commit into
mainfrom
codex/trino-auth-config-paths

Conversation

@bill-ph

@bill-ph bill-ph commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Trino authentication readiness assumed both provider files lived under /etc/trino. Coordinators using /etc/trino/coordinator therefore failed readiness even when their authentication files were correctly mounted.

Resolve each provider file from the selected coordinator container's explicit ConfigMap subPath mount. Reject missing or ambiguous mounts, retain credential verification and cache-refresh waiting, and identify the provider in sanitized observation errors. No new deployment setting is required. The runbook documents the supported mount contract.

Validation

  • Confirmed the new regression fails before the fix for the coordinator-directory layout and passes afterward.
  • just test-trino passed, including both layouts and rejected mount configurations.
  • Independent review found no blocking correctness, overengineering, or scope findings.
  • just lint reports the same 6 diagnostics as clean main; Kubernetes-tagged lint reports the same 61 diagnostics as clean main. Both baseline comparisons are identical, with no new diagnostics.
  • Not yet deployed; live tenant readiness remains to be verified after rollout.

@github-actions

Copy link
Copy Markdown

Test Impact Plan

Deterministic summary of how this PR changes tests, CI runners, and coverage-risk signals.

Summary

Area Added Changed Deleted
Test files 0 1 0
E2E/journey files 0 0 0
Workflow files 0 0 0

Signals

  • Test cases: +1 / -0
  • Assertions: +10 / -0
  • Skips or known failures added: 0
  • Workflow continue-on-error added: 0
  • Workflow path filters added: 0
  • Test commands removed from justfile: 0
  • E2E/journey retry lines added: 0

Coverage risk: neutral or increased

No coverage-reduction warnings detected.

@bill-ph
bill-ph merged commit 6ac99b3 into main Sep 18, 2026
29 checks passed
@bill-ph
bill-ph deleted the codex/trino-auth-config-paths branch September 18, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant