feat(surveys): auto-submit eligible survey responses - #591
Open
lucasheriques wants to merge 1 commit into
Open
lucasheriques wants to merge 1 commit into
lucasheriques wants to merge 1 commit into
Conversation
Carry skipSubmitButton through both native bridges and the internal Dart survey models. Submit ratings and single-choice answers immediately when enabled; keep explicit submission for open choices and multiple choice. Guard pending native responses against duplicate taps and disposed UI updates. Move survey behavior toward parity with web and native SDKs. Raise native floors to iOS 3.77.0 and Android 3.66.4; add a minor changeset. Validation: 660 Flutter tests passed, including 14 interaction cases (five failed before implementation). Dart analysis, formatting, public API snapshot check, Kotlin/Swift formatting, and iOS simulator/macOS/web example builds passed. Android release build awaits the new Maven artifact; the local composite fallback encountered native build configuration/lock incompatibilities. CodeScene exception: two added payload fields extend existing long Kotlin and Dart serializers; the gate reports small length-based degradations. The new tests and widget changes have no findings. Broader serializer refactoring is intentionally deferred to keep this change focused.
 The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified. Reviews (1) · Last reviewed commit: "feat(surveys): auto-submit eligible surv..." |
Contributor
posthog-flutter Compliance ReportDate: 2026-09-17 17:06:19 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Moves surveys toward feature parity across SDKs. With
skipSubmitButtonenabled, selecting a rating or a single choice submits the answer and follows the native SDK's next-question result. Multiple-choice questions and single-choice questions with an open choice keep their submit button.Passes the setting through the iOS/Android bridges and prevents duplicate submissions while a native response is pending. Requires iOS 3.77.0+ and Android 3.66.4+, from PostHog/posthog-ios#808 and PostHog/posthog-android#769.
Closes #262.
💚 How did you test it?
📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Codex, GitHub CLI, Flutter/Gradle/Xcode build tools, and CodeScene. Follows the native SDK eligibility rules and uses widget interaction tests to verify the Dart rendering path. Human review required.