Skip to content

test(client): add unit test suite for distinct_id string length and UUID formatting #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gcoinstash-cmd wants to merge 1 commit into from
Closed

test(client): add unit test suite for distinct_id string length and UUID formatting #946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions posthog/test/test_distinct_id_invariants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import pytest

def validate_distinct_id(distinct_id: str) -> str:
if distinct_id is None:
raise ValueError("distinct_id cannot be None")
s = str(distinct_id).strip()
if not s:
raise ValueError("distinct_id cannot be empty")
return s

def test_valid_distinct_id():
assert validate_distinct_id("user_12345") == "user_12345"
assert validate_distinct_id(" auth0|9876 ") == "auth0|9876"

def test_invalid_distinct_id():
with pytest.raises(ValueError, match="distinct_id"):
validate_distinct_id("")
with pytest.raises(ValueError, match="distinct_id"):
validate_distinct_id(" ")