fix: Return None for malformed feature flag payloads - #947
Draft
marandaneto wants to merge 1 commit into
Draft
marandaneto wants to merge 1 commit into
marandaneto wants to merge 1 commit into
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-09-14 06:39:56 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Member
Author
|
idk if this one should be fixed or if the other sdks should be fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Malformed JSON payloads currently return the raw string through
evaluate_flags(...).get_flag_payload(...), while the deprecatedget_feature_flag_payload(...)can raiseJSONDecodeError.Both APIs now use a shared parser that returns
Nonefor malformed or empty JSON strings, for local and server-provided payloads. Valid JSON and pre-decoded values are preserved.💚 How did you test it?
3781203againstorigin/mainreported no actionable findings.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Pi using file editing, shell tests, GitHub CLI, and the isolated autoreview helper. The requested behavior is to treat malformed JSON payloads as absent rather than return invalid strings or raise decoding errors. The change shares parsing between the newer and deprecated APIs and includes local and remote regression coverage. Human review is required.