cumPoolsCreateAGB handles where age==0 - #94
Merged
Merged
Conversation
DominiqueCaron
approved these changes
Sep 8, 2026
cboisvenue
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cumPoolsCreateAGBcurrently removes all rows of the input AGB table where age == 0 because the Boudewyn equations will not work when age == 0. This update manually sets all "merch", "foliage", and "other" pools to 0 if the total B (biomass) == 0, which allows the function to return pools when age == 0 and B == 0. It will fail if any rows have age==0 and B!=0.This saves a step in
LandRCBM_split3poolswhere we need to manually re-add the removed rows for every curve with(age = 0, merch = 0, foliage = 0, other = 0).Tests have been updated to verify that input of
(age = 0, B = 0)leads to an output of(age = 0, merch = 0, foliage = 0, other = 0)and that an input of(age = 0, B = 10)will fail.Other small updates:
This requires a small update to
LandRCBM_split3poolswhich I will PR if this change is accepted.