tests read Boudewyn parameters in setup - #95
Merged
Merged
Conversation
Contributor
Author
|
All tests pass; @cboisvenue I recommend that we merge! |
cboisvenue
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NFI parameter download throttling (see #91) may be due to tables being downloaded multiple times for different tests. This update will have all the relevant parameter tables downloaded a single time at test start up.
@cboisvenue has recommended we avoid having static parameter tables included as package data with CBMutils because they are subject to change over time. In total there are 8 tables with an average of ~1500 rows which is not a negligible amount of data to include in the package only for testing. Including table subsets may still be possible but some of our functions being tested attribute these parameters to our input data or provide a next best if no match found - it is important to check that this is working correctly so this would need to be done thoughtfully.
Watching to see if GHAs pass to determine if this is a sufficient solution to this issue.